Skip to content

Conversation

GuillaumeGomez
Copy link
Member

To reproduce the bug, go to https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_ast/ast.rs.html#537-541 and click on the Path link. The page won't scroll to the content.

r? @Urgau

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) A-rustdoc-js Area: Rustdoc's JS front-end labels Mar 5, 2022
@Dylan-DPC
Copy link
Member

@bors delegate @Urgau

Copy link
Member

@Urgau Urgau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works now as expected. Thanks.

@GuillaumeGomez
Copy link
Member Author

@bors: delegate=@Urgau

@bors
Copy link
Collaborator

bors commented Mar 5, 2022

✌️ @Urgau can now approve this pull request

@Urgau
Copy link
Member

Urgau commented Mar 5, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 5, 2022

📌 Commit 40e3b6e has been approved by Urgau

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 5, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2022
Rollup of 4 pull requests

Successful merges:

 - rust-lang#94630 (Update note about tier 2 docs.)
 - rust-lang#94633 (Suggest removing a semicolon after derive attributes)
 - rust-lang#94642 (Fix source code pages scroll)
 - rust-lang#94645 (do not attempt to open cgroup files under Miri)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 49d20c4 into rust-lang:master Mar 5, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 5, 2022
@GuillaumeGomez GuillaumeGomez deleted the source-code-scroll branch March 5, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-ui Area: Rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants